From 21e4795b0cf88a4a9ad0d32cab510f90bdfd19ed Mon Sep 17 00:00:00 2001 From: Michael James Date: Tue, 16 Oct 2018 22:02:17 -0600 Subject: [PATCH] best practice import order; avoid return after else --- awips/dataaccess/PyGeometryNotification.py | 2 +- dynamicserialize/SelfDescribingBinaryProtocol.py | 4 ++-- .../uf/common/dataplugin/gfe/db/objects/GridParmInfo.py | 3 +-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/awips/dataaccess/PyGeometryNotification.py b/awips/dataaccess/PyGeometryNotification.py index b942026..8884d43 100644 --- a/awips/dataaccess/PyGeometryNotification.py +++ b/awips/dataaccess/PyGeometryNotification.py @@ -10,9 +10,9 @@ # 09/07/17 6175 tgurney Override messageReceived # +import traceback import dynamicserialize from awips.dataaccess.PyNotification import PyNotification -import traceback class PyGeometryNotification(PyNotification): diff --git a/dynamicserialize/SelfDescribingBinaryProtocol.py b/dynamicserialize/SelfDescribingBinaryProtocol.py index ad3fdd0..85043ff 100644 --- a/dynamicserialize/SelfDescribingBinaryProtocol.py +++ b/dynamicserialize/SelfDescribingBinaryProtocol.py @@ -12,10 +12,10 @@ # # -from thrift.protocol.TProtocol import * -from thrift.protocol.TBinaryProtocol import * import struct import numpy +from thrift.protocol.TProtocol import * +from thrift.protocol.TBinaryProtocol import * FLOAT = 64 diff --git a/dynamicserialize/dstypes/com/raytheon/uf/common/dataplugin/gfe/db/objects/GridParmInfo.py b/dynamicserialize/dstypes/com/raytheon/uf/common/dataplugin/gfe/db/objects/GridParmInfo.py index 35ce07d..d78e9b2 100644 --- a/dynamicserialize/dstypes/com/raytheon/uf/common/dataplugin/gfe/db/objects/GridParmInfo.py +++ b/dynamicserialize/dstypes/com/raytheon/uf/common/dataplugin/gfe/db/objects/GridParmInfo.py @@ -42,8 +42,7 @@ class GridParmInfo(object): " RateParm: " + str(self.rateParm) + \ " GridType: " + self.gridType return out - else: - return "" + return "" def __eq__(self, other): if not isinstance(other, GridParmInfo):