From acaa5dee0f0bf568d579edc7d2c3690031c5db0a Mon Sep 17 00:00:00 2001 From: XANTRONIX Development Date: Tue, 11 Aug 2020 02:00:06 -0400 Subject: [PATCH] Don't change socket to SOCK_PROMISC for bad iface In src/server.c, server_setsockopt(), do not change socket state to SOCK_PROMISC if the requested interface cannot be found --- src/server.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/server.c b/src/server.c index c188a52..92e19f3 100644 --- a/src/server.c +++ b/src/server.c @@ -633,10 +633,6 @@ static int server_setsockopt(patty_ax25_server *server, goto error_read; } - if (data.state == PATTY_AX25_SOCK_PROMISC) { - sock->state = PATTY_AX25_SOCK_PROMISC; - } - if ((iface = patty_ax25_server_get_if(server, data.name)) == NULL) { response.ret = -1; response.eno = ENODEV; @@ -644,6 +640,10 @@ static int server_setsockopt(patty_ax25_server *server, goto error_get_if; } + if (data.state == PATTY_AX25_SOCK_PROMISC) { + sock->state = PATTY_AX25_SOCK_PROMISC; + } + patty_ax25_sock_bind_if(sock, iface); fd_watch(server, sock->fd);