From 3b1e341851094f9158abbaba9098ab124e50f731 Mon Sep 17 00:00:00 2001 From: XANTRONIX Development Date: Sat, 22 Aug 2020 22:54:11 -0500 Subject: [PATCH] Fix switch case fallthrough bugs in src/server.c Fix switch case fallthrough bugs in src/server.c in the following functions: * handle_rr() * handle_rnr() * handle_rej() --- src/server.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/server.c b/src/server.c index 10f261c..3838d80 100644 --- a/src/server.c +++ b/src/server.c @@ -1693,9 +1693,8 @@ static int handle_rr(patty_ax25_server *server, switch (frame->cr) { case PATTY_AX25_FRAME_COMMAND: - if (frame->pf) { - return patty_ax25_sock_send_rr(sock, PATTY_AX25_FRAME_RESPONSE, 1); - } + return frame->pf? + patty_ax25_sock_send_rr(sock, PATTY_AX25_FRAME_RESPONSE, 1): 0; case PATTY_AX25_FRAME_RESPONSE: sock_flow_start(server, sock); @@ -1718,9 +1717,8 @@ static int handle_rnr(patty_ax25_server *server, switch (frame->cr) { case PATTY_AX25_FRAME_COMMAND: - if (frame->pf) { - return patty_ax25_sock_send_rr(sock, PATTY_AX25_FRAME_RESPONSE, 1); - } + return frame->pf? + patty_ax25_sock_send_rr(sock, PATTY_AX25_FRAME_RESPONSE, 1): 0; case PATTY_AX25_FRAME_RESPONSE: sock_flow_stop(server, sock); @@ -1743,9 +1741,8 @@ static int handle_rej(patty_ax25_server *server, switch (frame->cr) { case PATTY_AX25_FRAME_COMMAND: - if (frame->pf) { - return patty_ax25_sock_send_rr(sock, PATTY_AX25_FRAME_RESPONSE, 1); - } + return frame->pf? + patty_ax25_sock_send_rr(sock, PATTY_AX25_FRAME_RESPONSE, 1): 0; case PATTY_AX25_FRAME_RESPONSE: sock_flow_start(server, sock);