From 00879d33c54b26a0f2a5aaf06a675f7679e690ef Mon Sep 17 00:00:00 2001 From: XANTRONIX Development Date: Thu, 22 Oct 2020 23:03:22 +0100 Subject: [PATCH] Fix strncpy() compilation warnings Fix strncpy() compilation warnings wherein the target string length did not account for a nul terminator --- bin/ax25dump.c | 2 +- bin/tncd.c | 2 +- src/server.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/ax25dump.c b/bin/ax25dump.c index f2cef90..f3df769 100644 --- a/bin/ax25dump.c +++ b/bin/ax25dump.c @@ -92,7 +92,7 @@ int main(int argc, char **argv) { goto error_client_socket; } - strncpy(ifreq.name, ifname, sizeof(ifreq.name)); + strncpy(ifreq.name, ifname, sizeof(ifreq.name)-1); ifreq.state = PATTY_AX25_SOCK_PROMISC; diff --git a/bin/tncd.c b/bin/tncd.c index 3f08b8b..9f55fc6 100644 --- a/bin/tncd.c +++ b/bin/tncd.c @@ -109,7 +109,7 @@ static int pty_promisc(patty_client *client, setsockopt_request.opt = PATTY_AX25_SOCK_IF; setsockopt_request.len = sizeof(ifreq); - strncpy(ifreq.name, ifname, sizeof(ifreq.name)); + strncpy(ifreq.name, ifname, sizeof(ifreq.name)-1); ifreq.state = PATTY_AX25_SOCK_PROMISC; call = PATTY_CLIENT_SETSOCKOPT; diff --git a/src/server.c b/src/server.c index 43e4a3a..acde16b 100644 --- a/src/server.c +++ b/src/server.c @@ -458,7 +458,7 @@ int patty_ax25_server_if_add(patty_ax25_server *server, goto error_if_fd; } - strncpy(entry->name, name, sizeof(entry->name)); + strncpy(entry->name, name, sizeof(entry->name)-1); entry->iface = iface;