Issue #2860 - Fix to not create empty substitution tags

Change-Id: I6734c61103b5bf9db3c27adfe0305cb5eb60d4ff

Former-commit-id: ecd5428e2adad5a0b8022d4a89a13a5a4d549dc1
This commit is contained in:
Mike Duff 2014-04-30 10:17:56 -05:00
parent 3259d4d44d
commit c0b2a19a2f

View file

@ -54,6 +54,7 @@ import com.raytheon.uf.edex.plugin.redbook.ingest.xml.RedbookMenusXML;
* Mar 07, 2014 2858 mpduff Initial creation * Mar 07, 2014 2858 mpduff Initial creation
* Mar 14, 2014 2855 mpduff Refactored common code. * Mar 14, 2014 2855 mpduff Refactored common code.
* Mar 19, 2014 2860 mpduff Implemented Redbook UpperAir. * Mar 19, 2014 2860 mpduff Implemented Redbook UpperAir.
* Apr 30, 2014 2860 mpduff Fixed instances of empty substitution tags.
* *
* </pre> * </pre>
* *
@ -168,15 +169,8 @@ public abstract class RedbookMenuUtil extends AbstractMenuUtil {
commonBundleMenuContribution.id = menuEntry.getId(); commonBundleMenuContribution.id = menuEntry.getId();
commonBundleMenuContribution.text = menuEntry.getText(); commonBundleMenuContribution.text = menuEntry.getText();
if (menuEntry.getMenuEntryList().size() > 0) { if (!menuEntry.getMenuEntryList().isEmpty()) {
List<VariableSubstitution> subList = new ArrayList<VariableSubstitution>(); List<VariableSubstitution> subList = new ArrayList<VariableSubstitution>();
for (MenuEntry substitute : menuEntry.getMenuEntryList()) {
VariableSubstitution var = new VariableSubstitution();
var.key = substitute.getKey();
var.value = substitute.getValue();
subList.add(var);
}
List<String> dataUriList = new ArrayList<String>(); List<String> dataUriList = new ArrayList<String>();
for (MenuEntry me : menuEntry.getMenuEntryList()) { for (MenuEntry me : menuEntry.getMenuEntryList()) {
@ -190,7 +184,6 @@ public abstract class RedbookMenuUtil extends AbstractMenuUtil {
} else if (MenuEntryType.DataUri == me.getType()) { } else if (MenuEntryType.DataUri == me.getType()) {
dataUriList.add(me.getDataUri()); dataUriList.add(me.getDataUri());
} }
} }
commonBundleMenuContribution.substitutions = subList commonBundleMenuContribution.substitutions = subList