From 82b526851a8c8f6e186a73b6dd3104a17f38c250 Mon Sep 17 00:00:00 2001 From: Roger Ferrel Date: Tue, 12 Mar 2013 16:58:06 -0500 Subject: [PATCH] Issue #1783 Modified DefaultPluginArchiveFileNameFormatter to use LinkList instead of ArrayList. Change-Id: I156fc0f335320489923ae31f6e790f5e86ac26f4 Former-commit-id: b5743e8f9b2b1c123d4cb154ba823f0c79abc411 [formerly c5a2786c848fe88dde77131a24212a03157ceb80 [formerly 8ec4ac592389af736c45a11d9c6f6613fd9da504]] Former-commit-id: c5a2786c848fe88dde77131a24212a03157ceb80 Former-commit-id: f912d9ece307ed067ae9b97ec6fd3eee08cb3f3a --- .../DefaultPluginArchiveFileNameFormatter.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/edexOsgi/com.raytheon.uf.edex.maintenance/src/com/raytheon/uf/edex/maintenance/archive/DefaultPluginArchiveFileNameFormatter.java b/edexOsgi/com.raytheon.uf.edex.maintenance/src/com/raytheon/uf/edex/maintenance/archive/DefaultPluginArchiveFileNameFormatter.java index b0d8f309a4..2cdec811dc 100644 --- a/edexOsgi/com.raytheon.uf.edex.maintenance/src/com/raytheon/uf/edex/maintenance/archive/DefaultPluginArchiveFileNameFormatter.java +++ b/edexOsgi/com.raytheon.uf.edex.maintenance/src/com/raytheon/uf/edex/maintenance/archive/DefaultPluginArchiveFileNameFormatter.java @@ -20,12 +20,12 @@ package com.raytheon.uf.edex.maintenance.archive; import java.io.File; -import java.util.ArrayList; import java.util.Calendar; import java.util.Date; import java.util.HashMap; import java.util.HashSet; import java.util.Iterator; +import java.util.LinkedList; import java.util.List; import java.util.Map; import java.util.Set; @@ -39,7 +39,7 @@ import com.raytheon.uf.edex.database.DataAccessLayerException; import com.raytheon.uf.edex.database.plugin.PluginDao; /** - * TODO Add Description + * The default implementation of IPluginArchiveFileNameFormatter. * *
  * 
@@ -48,6 +48,9 @@ import com.raytheon.uf.edex.database.plugin.PluginDao;
  * Date         Ticket#    Engineer    Description
  * ------------ ---------- ----------- --------------------------
  * Apr 20, 2012            dgilling     Initial creation
+ * Mar 12, 2013 1783       rferrel      Replace ArrayList with LinkedList to
+ *                                       remove excess capacity and reduce
+ *                                       time to resize a growing list.
  * 
  * 
* @@ -67,6 +70,7 @@ public class DefaultPluginArchiveFileNameFormatter implements * com.raytheon.uf.edex.database.plugin.PluginDao, java.util.Map, * java.util.Calendar, java.util.Calendar) */ + @SuppressWarnings("rawtypes") @Override public Map> getPdosByFile( String pluginName, PluginDao dao, @@ -91,7 +95,7 @@ public class DefaultPluginArchiveFileNameFormatter implements newFileEntries.add(path); List list = pdoMap.get(path); if (list == null) { - list = new ArrayList(pdos.size()); + list = new LinkedList(); pdoMap.put(path, list); } list.add(pdo); @@ -117,7 +121,7 @@ public class DefaultPluginArchiveFileNameFormatter implements newFileEntries.add(path); List list = pdoMap.get(path); if (list == null) { - list = new ArrayList(pdos.size()); + list = new LinkedList(); pdoMap.put(path, list); } list.add(pdo);