xan/awips2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Issue #1968 Prevent deadlock on thinclient startup

Browse source 
Change-Id: I522082d3c633b583e9b72941ec17464731ceba5e

Former-commit-id: ff6220147b [formerly ff6220147b [formerly fd9305775d1c0de574d1c0c9b47aac911b356de6]]
Former-commit-id: dbd1f3d5e5
Former-commit-id: 0929802c01
This commit is contained in:
Dustin Johnson 2013-05-01 15:48:15 -05:00
parent 7a4506d00b
commit 17be4bbb77
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
edexOsgi/com.raytheon.uf.common.serialization/src/com/raytheon/uf/common/serialization/SerializationUtil.java
View file

@ -45,6 +45,7 @@ import com.raytheon.uf.common.util.ServiceLoaderUtil;
* to accept class parameter, deprecate old versions. Improve performance
* of getJaxbManager().
* Feb 07, 2013 1543 djohnson Use ServiceLoader to find how to load jaxbable classes, defaulting to SerializableManager.
* May 01, 2013 1968 djohnson Prevent deadlock due to SerializableManager threads needing to serialize things.
*
* </pre>
*
@ -54,10 +55,6 @@ import com.raytheon.uf.common.util.ServiceLoaderUtil;
public final class SerializationUtil {
private static final IJaxbableClassesLocator jaxbableClassesLocator = ServiceLoaderUtil
.load(IJaxbableClassesLocator.class,
SerializableManager.getInstance());
private static volatile JAXBManager jaxbManager;
private SerializationUtil() {
@ -79,7 +76,12 @@ public final class SerializationUtil {
synchronized (SerializationUtil.class) {
result = jaxbManager;
if (result == null) {
List<Class<ISerializableObject>> jaxbClasses = jaxbableClassesLocator
// This cannot be eagerly created as
// SerializableManager.getInstance() spawns threads which
// were causing a deadlock
List<Class<ISerializableObject>> jaxbClasses = ServiceLoaderUtil
.load(IJaxbableClassesLocator.class,
SerializableManager.getInstance())
.getJaxbables();
jaxbManager = result = new JAXBManager(
jaxbClasses.toArray(new Class[jaxbClasses.size()]));